This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(adm): Use Firefox's full_keyword algorithm #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, this algorithm never suggests more than the rest of the current word. Fixes #213
ncloudioj
reviewed
Nov 10, 2021
| new_suggestions.insert(keyword.clone(), merino_suggestion.clone()); | ||
| let full_keyword = Self::get_full_keyword(keyword, &adm_suggestion.keywords); | ||
|
|
||
| if keyword == "amaz" { |
ncloudioj
approved these changes
Nov 10, 2021
| /// the available keywords. | ||
| /// | ||
| /// 1. Find the first keyword phrase that has more words than the query. Use | ||
| /// its first `queryWords.length` words as the full keyword. e.g., if the |
There was a problem hiding this comment.
Could you update the doc to reflect the variables used in the function? queryWords and result.keywords are a little confusing here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, this algorithm never suggests more than the rest of the current word.
Fixes #213